I addressed the comments. Please take another look.

https://codereview.chromium.org/12177015/diff/3001/src/string.js
File src/string.js (right):

https://codereview.chromium.org/12177015/diff/3001/src/string.js#newcode271
src/string.js:271: SubString(subject, match[CAPTURE1], subject.length);
On 2013/02/05 09:30:58, ulan wrote:
I would reformat by putting the first argument of ExpandReplacement in
a new
line.

Not entirely sure what you mean here.

https://codereview.chromium.org/12177015/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to