Comments attached.
https://codereview.chromium.org/12177012/diff/3001/src/x64/assembler-x64.cc
File src/x64/assembler-x64.cc (right):
https://codereview.chromium.org/12177012/diff/3001/src/x64/assembler-x64.cc#newcode1511
src/x64/assembler-x64.cc:1511: } else if (is_int32(value)) {
What is the purpose of this change?
https://codereview.chromium.org/12177012/diff/3001/src/x64/macro-assembler-x64.cc
File src/x64/macro-assembler-x64.cc (right):
https://codereview.chromium.org/12177012/diff/3001/src/x64/macro-assembler-x64.cc#newcode2921
src/x64/macro-assembler-x64.cc:2921: cvtqsi2sd(dst, src);
The uses of this indicate that the input is indeed uint32, so I think
thet assert is sufficient.
https://codereview.chromium.org/12177012/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
