On 2013/02/06 11:44:41, Zheng Liu wrote:
On 2013/02/06 11:39:18, Yang wrote:
>
https://codereview.chromium.org/12177012/diff/3001/src/x64/assembler-x64.cc
> File src/x64/assembler-x64.cc (right):
>
>
https://codereview.chromium.org/12177012/diff/3001/src/x64/assembler-x64.cc#newcode1511
> src/x64/assembler-x64.cc:1511: } else if (is_int32(value)) {
> On 2013/02/06 11:34:08, Zheng Liu wrote:
> > On 2013/02/06 10:28:59, Yang wrote:
> > > What is the purpose of this change?
> >
> > Code might be smaller, as [mov r64, imm32] always have a prefix.
> > MacroAssembler::Set() did similar things.
>
> But this change seems to be to the effect of changing
>
> if (A) {
> B;
> } else if (C) {
> D;
> }
>
> into
>
> if (C) {
> D;
> } else if (A) {
> B;
> }
>
> I don't see any difference besides changing the order.
I think that cond A & C overlaps, e.g. is_uint32(0x1) and is_int32(0x1)
are
both
true.
Ah. Good point. Thanks for the explaination. LGTM.
https://codereview.chromium.org/12177012/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
