Comments addressed. Architecture ports implemented. This is ready for
another
round of review.
https://codereview.chromium.org/12220074/diff/1/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/12220074/diff/1/src/code-stubs-hydrogen.cc#newcode167
src/code-stubs-hydrogen.cc:167: true, i));
On 2013/02/08 12:45:49, Jakob wrote:
nit: fits on last line
Done.
https://codereview.chromium.org/12220074/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/12220074/diff/1/src/hydrogen-instructions.h#newcode3625
src/hydrogen-instructions.h:3625: class HInstanceSize: public
HTemplateInstruction<1> {
On 2013/02/08 12:03:41, danno wrote:
Could you add a TODO so that we revisit this when we fix FieldLoads
and Stores?
Done.
https://codereview.chromium.org/12220074/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/12220074/diff/1/src/hydrogen.cc#newcode654
src/hydrogen.cc:654: failure_block->Goto(failure_block_);
On 2013/02/08 12:45:49, Jakob wrote:
This line looks weird. Too bad the edge split form requirement doesn't
allow us
to get by without it.
Yeah, I know, it also annoys me that we need this fall-through blocks in
between and that merge blocks cannot be proceeded by other control-flow
instructions besides HGoto. But fixing that is outside the scope of this
CL.
https://codereview.chromium.org/12220074/diff/1/src/hydrogen.cc#newcode678
src/hydrogen.cc:678: builder_->set_current_block(failure_block_);
On 2013/02/08 12:45:49, Jakob wrote:
I think this line is not needed if you
s/builder_->current_block()/failure_block_/ in the line below.
Done.
https://codereview.chromium.org/12220074/diff/1/src/hydrogen.h
File src/hydrogen.h (right):
https://codereview.chromium.org/12220074/diff/1/src/hydrogen.h#newcode934
src/hydrogen.h:934: Zone* zone() { return builder_->zone(); }
On 2013/02/08 12:45:49, Jakob wrote:
nit: methods before properties
Done (also for the other builders below).
https://codereview.chromium.org/12220074/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
