I really like this CL. LGTM with a couple small issues.
https://codereview.chromium.org/12220074/diff/3021/src/arm/deoptimizer-arm.cc
File src/arm/deoptimizer-arm.cc (right):
https://codereview.chromium.org/12220074/diff/3021/src/arm/deoptimizer-arm.cc#newcode561
src/arm/deoptimizer-arm.cc:561: PrintF(" 0x%08x: [top + %d] <- 0x%08x
; function (stub sentinel)\n",
nit: it's actually the stub failure sentinel
https://codereview.chromium.org/12220074/diff/3021/src/hydrogen.h
File src/hydrogen.h (right):
https://codereview.chromium.org/12220074/diff/3021/src/hydrogen.h#newcode918
src/hydrogen.h:918: BailoutId id = BailoutId::StubEntry());
I think it's a good idea to not provide a default. If this builder ever
gets used in an inlined stub in a JS function, then it will need the
right ast_id, and with the default construction it's easy to forget to
thread it through.
https://codereview.chromium.org/12220074/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
