Sorry, I don't like this change. It adds a very non-intuitive condition --
I'm
not sure I fully understand the implications even after thinking about it
for
several minutes. Further, I'm concerned that this breaks ia32 Chromium
compilation on x64 systems (haven't tested it, though, because the build
environment for that is a bit involved to set up).
Could you tell me more about your proposed changes to configure the compiler
"through the Makefiles"? Is the new system based on GYP variables? If so, it
should be possible to use that information directly, either as input to the
feature detection shell command, or to avoid calling that command
altogether.
https://codereview.chromium.org/12218113/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
