On 2013/02/12 12:29:47, Jakob wrote:
Sorry, I don't like this change. It adds a very non-intuitive condition --
I understand your objection, I don't much like the 2nd line of this patch
either.
What we are trying to do is avoid setting the toolchain vars in the
environment,
and instead have them set via GYP variables. And it works, EXCEPT for the
setting of the compiler flags, which this patch is trying to address.
The Chromium src/build/common.gypi has the changes for mips at r179820
(eb5f167). Currently I have my Chromium tree pulled at r181996 (for the
following line # refs).
At src/build/common.gypi line 3970 we set GYP vars for the toolchain:
['target_arch=="mipsel"', {
'make_global_settings': [
['CC', '<(sysroot)/../bin/mipsel-linux-gnu-gcc'],
['CXX', '<(sysroot)/../bin/mipsel-linux-gnu-g++'],
['LINK', '$(CXX)'],
['CC.host', '<!(which gcc)'],
['CXX.host', '<!(which g++)'],
['LINK.host', '<!(which g++)'],
],
}],
We made this similar to the previous OS=="android" section, which has the
comment:
# Hardcode the compiler names in the Makefile so that
# it won't depend on the environment at make time.
which seems like a good idea.
When the top-level Makefile is generated the toolchain paths are set there:
CXX = $(abspath
/opt/paul/chrome/2-mips-chrome/src/native_client/toolchain/linux_mips-trusted/sysroot/../bin/mipsel-linux-gnu-g++)
This toolchain is used for v8 build, but since we do not have $CXX in the
environment, we don't calculate 'mipscompiler' var correctly, so we miss
necessary mips gcc flags, AND we also erroneously pick up the m32flag
(-m32).
Any suggestions for how to properly set those flags based on the GYP vars
we do
have would be greatly appreciated.
I'll send you a email with a patch to build our toolchain in the Chromium
tree
should you wish to go that far. Everything else is present in Chromium
source.
thanks,
paul
https://codereview.chromium.org/12218113/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
