LGTM.
https://codereview.chromium.org/12211128/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/12211128/diff/1/src/hydrogen.cc#newcode2737
src/hydrogen.cc:2737: instr->SetSideEffectDominator(changes_flag,
other);
There is another corner-case that is not yet covered. If
SetSideEffectDominator() removes the instruction from the graph, it
might still be present in the GVN map. This might lead to a subsequent
call to DeleteAndReplaceWith() where "other" is no longer in the graph.
I don't think this happens with the graphs we build ATM, but it is a
general problem when we allow SetSideEffectDominator() so delete
instructions from the graph. I am find with landing this change to fix
the immediate problem though.
https://codereview.chromium.org/12211128/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
