Reviewers: Michael Starzinger,
Description:
Don't try to unlink instructions twice during GVN
BUG=chrome:175141
Please review this at https://codereview.chromium.org/12211128/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen.cc
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index
7869d71687cf5d4f2554fcc3323ee554a6a193f2..e1cf70a0250cb2f281dda7e356fd318b7778754a
100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -2720,7 +2720,8 @@ void HGlobalValueNumberer::AnalyzeGraph() {
map->Add(instr, zone());
}
}
- if (instr->CheckFlag(HValue::kTrackSideEffectDominators)) {
+ if (instr->IsLinked() &&
+ instr->CheckFlag(HValue::kTrackSideEffectDominators)) {
for (int i = 0; i < kNumberOfTrackedSideEffects; i++) {
HValue* other = dominators->at(i);
GVNFlag changes_flag = HValue::ChangesFlagFromInt(i);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
