First round of comments. As discussed offline, could you rebase this CL so
that
it contains Toon's comments from the related CL? I will then do the final
round
ASAP.
https://codereview.chromium.org/12224035/diff/8001/src/objects-debug.cc
File src/objects-debug.cc (right):
https://codereview.chromium.org/12224035/diff/8001/src/objects-debug.cc#newcode608
src/objects-debug.cc:608: DependentCodes::kWeaklyEmbeddedGroup, this));
Indentation is off.
https://codereview.chromium.org/12224035/diff/8001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/12224035/diff/8001/src/objects.h#newcode4697
src/objects.h:4697: // the number of codes is less than the length of
the array.
Can we also add a sentence stating that the order of the code objects
within a group is not preserved by this implementation?
https://codereview.chromium.org/12224035/diff/8001/src/objects.h#newcode4719
src/objects.h:4719: inline void clear_code_at(int i);
As discussed offline: Can we (visually) separate the low-level from the
high-level accessors? The low-level ones should only be used by the GC,
adding a comment in that regard would help to clarify that.
https://codereview.chromium.org/12224035/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
