Also renamed the factory methods.
On 2013/02/20 17:52:18, Yang wrote:
The issue was that -Infinity was not being constant folded, but still
computed
as -1 * Infinity. Math.round of that deopts.
On 2013/02/20 17:51:15, Yang wrote:
>
https://chromiumcodereview.appspot.com/12315005/diff/1/src/hydrogen-instructions.cc
> File src/hydrogen-instructions.cc (right):
>
>
https://chromiumcodereview.appspot.com/12315005/diff/1/src/hydrogen-instructions.cc#newcode2839
> src/hydrogen-instructions.cc:2839: if (isinf(d)) { // +Inifinity and
-Infinity.
> On 2013/02/20 15:31:04, Jakob wrote:
> > nit: "Inifinity" sounds nice, but has an "i" too many.
>
> Done.
>
>
https://chromiumcodereview.appspot.com/12315005/diff/1/src/hydrogen-instructions.cc#newcode2882
> src/hydrogen-instructions.cc:2882: if (Double(d).Exponent() >= 0) return
> H_CONSTANT_DOUBLE(d);
> On 2013/02/20 15:31:04, Jakob wrote:
> > I'm not convinced having this "fast path" is worthwhile, but
whatever...
>
> This is not a fast path, but for correctness. The rounding error may
result
in
> 1.0 being added when you try to add 0.5.
>
> https://chromiumcodereview.appspot.com/12315005/diff/1/src/hydrogen.cc
> File src/hydrogen.cc (right):
>
>
https://chromiumcodereview.appspot.com/12315005/diff/1/src/hydrogen.cc#newcode7900
> src/hydrogen.cc:7900: zone(), context, left, kMathPowHalf);
> On 2013/02/20 15:31:04, Jakob wrote:
> > nit: now this indentation is just inconsistent with everything else.
>
> Done.
>
>
https://chromiumcodereview.appspot.com/12315005/diff/1/test/mjsunit/fold-constants.js
> File test/mjsunit/fold-constants.js (right):
>
>
https://chromiumcodereview.appspot.com/12315005/diff/1/test/mjsunit/fold-constants.js#newcode257
> test/mjsunit/fold-constants.js:257:
> On 2013/02/20 15:31:04, Jakob wrote:
> > git/patch complains about this empty line here.
>
> Done.
https://chromiumcodereview.appspot.com/12315005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
