LGTM with nits.
https://chromiumcodereview.appspot.com/12315005/diff/10002/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://chromiumcodereview.appspot.com/12315005/diff/10002/src/hydrogen-instructions.cc#newcode2756
src/hydrogen-instructions.cc:2756: Zone* zone, HValue* context, HValue*
left, HValue* right) { \
nit: for method/function declarations (as opposed to calls), every
parameter goes on its own line (unless everything, including the method
name, fits on one line).
Again several times below.
https://chromiumcodereview.appspot.com/12315005/diff/10002/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://chromiumcodereview.appspot.com/12315005/diff/10002/src/hydrogen-instructions.h#newcode3898
src/hydrogen-instructions.h:3898: HPower(HValue* left, HValue* right) {
private ctor please
https://chromiumcodereview.appspot.com/12315005/diff/10002/src/hydrogen-instructions.h#newcode3954
src/hydrogen-instructions.h:3954: HAdd(HValue* context, HValue* left,
HValue* right)
private ctor please
https://chromiumcodereview.appspot.com/12315005/diff/10002/src/hydrogen-instructions.h#newcode4002
src/hydrogen-instructions.h:4002: HSub(HValue* context, HValue* left,
HValue* right)
private ctor please
https://chromiumcodereview.appspot.com/12315005/diff/10002/src/hydrogen-instructions.h#newcode5467
src/hydrogen-instructions.h:5467: HStringCharFromCode(HValue* context,
HValue* char_code) {
private ctor please
https://chromiumcodereview.appspot.com/12315005/diff/10002/src/hydrogen-instructions.h#newcode5500
src/hydrogen-instructions.h:5500: explicit HStringLength(HValue* string)
: HUnaryOperation(string) {
private ctor please
https://chromiumcodereview.appspot.com/12315005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
