https://codereview.chromium.org/12082101/diff/5004/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/12082101/diff/5004/src/mark-compact.cc#newcode3868
src/mark-compact.cc:3868: WaitUntilSweepingCompleted();
On 2013/02/20 18:20:07, Michael Starzinger wrote:
The ordering of the calls is off, in the "parallel sweeping" mode this
would
cause the evacuation candidates to be release before they are actually
evacuated.
I would suggest to add a FinalizeSweeping() method that is called
after
WaitUntilSweepingComplete() returns on all other call-sites ...
Done.
https://codereview.chromium.org/12082101/diff/5004/src/mark-compact.cc#newcode3887
src/mark-compact.cc:3887: if (!AreSweeperThreadsActivated()) {
The right condition is "if (!FLAG_concurrent_sweeping)" since it has to
be finalized in parallel and sequential mode.
On 2013/02/20 18:20:07, Michael Starzinger wrote:
... but called down here at this call-site. Also I would change the
if-cascade
to use the same predicates:
if (how_to_sweep == PARALLEL_CONSERVATIVE) {
if (FLAG_parallel_sweeping && !FLAG_concurrent_sweeping) {
FinalizeSweeping();
}
}
https://codereview.chromium.org/12082101/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
