https://codereview.chromium.org/12082101/diff/12001/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/12082101/diff/12001/src/mark-compact.cc#newcode538
src/mark-compact.cc:538: bool
MarkCompactCollector::WaitUntilSweepingCompleted() {
Why do you return a boolean here? IMHO this makes the call sites too
complex, I would just rely on FinalizeSweeping() to be a no-op in those
cases. I'll leave that up to you.
https://codereview.chromium.org/12082101/diff/12001/src/mark-compact.cc#newcode3876
src/mark-compact.cc:3876: if (FLAG_parallel_sweeping &&
!FLAG_concurrent_sweeping) {
How about moving all of this magic into the how_to_sweep variable by
introducing a CONCURRENT_CONSERVATIVE on top of the existing
PARALLEL_CONSERVATIVE?
https://codereview.chromium.org/12082101/diff/12001/src/mark-compact.cc#newcode3896
src/mark-compact.cc:3896: if (!FLAG_concurrent_sweeping) {
This is still not entirely correct, it _has_ to depend of the
how_to_sweep variable because that determines how the pages were swept.
https://codereview.chromium.org/12082101/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
