https://codereview.chromium.org/12317044/diff/1/src/deoptimizer.cc
File src/deoptimizer.cc (right):
https://codereview.chromium.org/12317044/diff/1/src/deoptimizer.cc#newcode1676
src/deoptimizer.cc:1676: return -1;
Add a "// Minus receiver." comment to the end of this line to explain
this magic -1 value.
https://codereview.chromium.org/12317044/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/12317044/diff/1/src/heap.cc#newcode6212
src/heap.cc:6212: bool Heap::Prepare() {
I think it makes more sense to keep this method be called SetUp() and
instead rename the latter one to CreateHeapObject().
https://codereview.chromium.org/12317044/diff/1/src/heap.cc#newcode6321
src/heap.cc:6321: store_buffer()->SetUp();
Also is it possible to move all of the steps that happen after heap
object creation (i.e. store buffer setup and relocation mutex creation)
into the above method? Thereby we could get rid of the whole
create_heap_objects argument and only call this method if no
deserializer is present.
https://codereview.chromium.org/12317044/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/12317044/diff/1/src/hydrogen.cc#newcode638
src/hydrogen.cc:638: BailoutId id)
Still fits into one line.
https://codereview.chromium.org/12317044/diff/1/src/isolate.cc
File src/isolate.cc (right):
https://codereview.chromium.org/12317044/diff/1/src/isolate.cc#newcode1
src/isolate.cc:1: // Copyright 2013 the V8 project authors. All rights
reserved.
I thought we don't change the copyright year anymore?
https://codereview.chromium.org/12317044/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
