Feedback addressed.
https://codereview.chromium.org/12317044/diff/2010/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/12317044/diff/2010/src/heap.h#newcode484
src/heap.h:484: // without actually actually creating any objects.
On 2013/02/25 12:00:57, Michael Starzinger wrote:
Drop one of the two "actually" in the comment.
Done.
https://codereview.chromium.org/12317044/diff/2010/src/isolate.cc
File src/isolate.cc (right):
https://codereview.chromium.org/12317044/diff/2010/src/isolate.cc#newcode2043
src/isolate.cc:2043: V8::FatalProcessOutOfMemory("heap preparation");
On 2013/02/25 12:00:57, Michael Starzinger wrote:
s/heap preparation/heap setup/
Done.
https://codereview.chromium.org/12317044/diff/2010/src/isolate.cc#newcode2049
src/isolate.cc:2049: // SetUp the object heap.
On 2013/02/25 12:00:57, Michael Starzinger wrote:
Move this comment up to before the assertion in line 2041.
Done.
https://codereview.chromium.org/12317044/diff/2010/src/isolate.cc#newcode2052
src/isolate.cc:2052: V8::FatalProcessOutOfMemory("heap setup");
On 2013/02/25 12:00:57, Michael Starzinger wrote:
s/heap setup/heap object creation/
Done.
https://codereview.chromium.org/12317044/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
