https://codereview.chromium.org/12379045/diff/1/src/arm/deoptimizer-arm.cc
File src/arm/deoptimizer-arm.cc (right):
https://codereview.chromium.org/12379045/diff/1/src/arm/deoptimizer-arm.cc#newcode557
src/arm/deoptimizer-arm.cc:557: void
Deoptimizer::FillStubFailureTrampolineFrame(
The name is maybe a little bit misleading. How about How about
DoComputePlatformCompiledStubFrame? The current name suggests that this
method does all the work, when in fact it only does the
platform-specific piece.
https://codereview.chromium.org/12379045/diff/1/src/arm/frames-arm.cc
File src/arm/frames-arm.cc (right):
https://codereview.chromium.org/12379045/diff/1/src/arm/frames-arm.cc#newcode37
src/arm/frames-arm.cc:37: #include "macro-assembler-arm.h"
Why the different includes here compared to other platforms?
https://codereview.chromium.org/12379045/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
