Addressed comments.
https://codereview.chromium.org/12379045/diff/1/src/arm/deoptimizer-arm.cc
File src/arm/deoptimizer-arm.cc (right):
https://codereview.chromium.org/12379045/diff/1/src/arm/deoptimizer-arm.cc#newcode557
src/arm/deoptimizer-arm.cc:557: void
Deoptimizer::FillStubFailureTrampolineFrame(
On 2013/03/05 13:54:04, danno wrote:
The name is maybe a little bit misleading. How about How about
DoComputePlatformCompiledStubFrame? The current name suggests that
this method
does all the work, when in fact it only does the platform-specific
piece.
Done. As discussed offline: IMHO the DoComputeFoo prefix doesn't really
apply here, as it is not generating a frame. How about
SetPlatformCompiledStubRegisters? That includes the indication that it
is platform-specific and that it only sets a few registers.
https://codereview.chromium.org/12379045/diff/1/src/arm/frames-arm.cc
File src/arm/frames-arm.cc (right):
https://codereview.chromium.org/12379045/diff/1/src/arm/frames-arm.cc#newcode37
src/arm/frames-arm.cc:37: #include "macro-assembler-arm.h"
On 2013/03/05 13:54:04, danno wrote:
Why the different includes here compared to other platforms?
Unfortunately the "cp" register is defined as part of the MacroAssembler
whereas all other registers are defined as part of the Assembler on ARM.
On the other architectures all of the registers are defined as part of
the Assembler.
https://codereview.chromium.org/12379045/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
