Revision: 13824
Author: [email protected]
Date: Tue Mar 5 05:54:03 2013
Log: fix x32 handling of Atomic64
The x32 logic for the size of Atomic64 handles NaCL, but misses
the Linux case. Check the standard __ILP32__ to handle that too.
This has been fixed in the Chromium base tree already:
https://codereview.chromium.org/12186005/
BUG=chromium-os:36866
TEST=compiled the code for x86_64 (64bit) & x86_64 (x32)
Review URL: https://codereview.chromium.org/12374065
Patch from Mike Frysinger <[email protected]>.
http://code.google.com/p/v8/source/detail?r=13824
Modified:
/branches/bleeding_edge/src/atomicops.h
=======================================
--- /branches/bleeding_edge/src/atomicops.h Tue Nov 13 13:38:00 2012
+++ /branches/bleeding_edge/src/atomicops.h Tue Mar 5 05:54:03 2013
@@ -58,7 +58,7 @@
#ifdef V8_HOST_ARCH_64_BIT
// We need to be able to go between Atomic64 and AtomicWord implicitly.
This
// means Atomic64 and AtomicWord should be the same type on 64-bit.
-#if defined(__APPLE__)
+#if defined(__ILP32__) || defined(__APPLE__)
// MacOS is an exception to the implicit conversion rule above,
// because it uses long for intptr_t.
typedef int64_t Atomic64;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.