Thanks, Danno, comments applied.
https://codereview.chromium.org/13426006/diff/19011/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/13426006/diff/19011/src/hydrogen-instructions.h#newcode3194
src/hydrogen-instructions.h:3194: ASSERT(has_double_value_);
On 2013/04/08 20:51:21, danno wrote:
Any reason this has to be an assert? Why not just return "false" if
has_double_value_ is false?
Good idea, done.
https://codereview.chromium.org/13426006/diff/19011/src/hydrogen-instructions.h#newcode3237
src/hydrogen-instructions.h:3237: return !representation().IsDouble() ||
ImmortalImmovable();
On 2013/04/08 20:51:21, danno wrote:
|| IsSpecialDouble instead of || ImmortanImmovable?
Now I see, thanks.
https://codereview.chromium.org/13426006/diff/19011/src/hydrogen-instructions.h#newcode3343
src/hydrogen-instructions.h:3343: return
FixedDoubleArray::is_the_hole_nan(double_value_);
On 2013/04/08 20:51:21, danno wrote:
Since this is only used once, it's probably fine just to inline
FixedDoubleArray::is_the_hole_nan(double_value_) in "IsTheHole"
Also in IsSpecialDouble(), but that is okay, this method is awkward.
https://codereview.chromium.org/13426006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
