lgtm with comments
https://codereview.chromium.org/13426006/diff/26001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/13426006/diff/26001/src/hydrogen-instructions.h#newcode3204
src/hydrogen-instructions.h:3204:
nit: remove added whitespace
https://codereview.chromium.org/13426006/diff/26001/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/13426006/diff/26001/src/ia32/lithium-codegen-ia32.cc#newcode370
src/ia32/lithium-codegen-ia32.cc:370: if
(!CpuFeatures::IsSupported(SSE2)) {
nit: How about putting the following 7 lines in a utility function
called "FlushX87StackIfNecessary?"
https://codereview.chromium.org/13426006/diff/26001/src/ia32/lithium-codegen-ia32.cc#newcode386
src/ia32/lithium-codegen-ia32.cc:386: // Make sure the floating point
stack is either empty or has one item,
This code might be useful elsewhere. How about putting it into the
macro-assembler in a function called "CheckX87StackIsEmpty()"
https://codereview.chromium.org/13426006/diff/26001/src/ia32/lithium-gap-resolver-ia32.cc
File src/ia32/lithium-gap-resolver-ia32.cc (right):
https://codereview.chromium.org/13426006/diff/26001/src/ia32/lithium-gap-resolver-ia32.cc#newcode378
src/ia32/lithium-gap-resolver-ia32.cc:378: cgen_->PopX87();
Slightly faster might be to just store rather that pop and store with a
push... but it's probably not important.
https://codereview.chromium.org/13426006/diff/26001/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):
https://codereview.chromium.org/13426006/diff/26001/src/ia32/lithium-ia32.cc#newcode2270
src/ia32/lithium-ia32.cc:2270: } else {
nit: no need for the additional scope, just do a "else if"
https://codereview.chromium.org/13426006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
