lgtm with comments
https://codereview.chromium.org/14296009/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/14296009/diff/1/src/hydrogen.cc#newcode8552
src/hydrogen.cc:8552: printf("cool\n");
Please remove.
https://codereview.chromium.org/14296009/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/14296009/diff/1/src/runtime.cc#newcode2419
src/runtime.cc:2419: if (char_code->ToArrayIndex(&code)) {
This currently works by accident I presume; given that ToArrayIndex has
a buggy implementation. 0xFFFFFFFF isn't a valid array index, even
though currently we interpret it as such. This probably wants to convert
it to a valid UInt32; probably best to fix up the API usage to avoid
future breakage. And maybe add a test for 0xFFFFFFFF if there isn't one
yet.
https://codereview.chromium.org/14296009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
