Reviewers: mvstanton,
Message:
Committed patchset #1 manually as r14295 (presubmit successful).
Description:
Fixed evaluation order problem found by GCMole.
[email protected]
Committed: http://code.google.com/p/v8/source/detail?r=14295
Please review this at https://codereview.chromium.org/14178006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/runtime.cc
Index: src/runtime.cc
diff --git a/src/runtime.cc b/src/runtime.cc
index
4b86d51212f1b8f56efeaced259a7e9c1e9c7599..b5295b808b8623b7b10fa15d32ee3458cab6239a
100644
--- a/src/runtime.cc
+++ b/src/runtime.cc
@@ -825,8 +825,8 @@ RUNTIME_FUNCTION(MaybeObject*,
Runtime_TypedArrayInitialize) {
ASSERT(byte_length % elementSize == 0);
size_t length = byte_length / elementSize;
- holder->set_length(
- *isolate->factory()->NewNumber(static_cast<double>(length)));
+ Handle<Object> length_obj = isolate->factory()->NewNumber(length);
+ holder->set_length(*length_obj);
Handle<ExternalArray> elements =
isolate->factory()->NewExternalArray(
static_cast<int>(length), arrayType,
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
