Revision: 14295
Author:   [email protected]
Date:     Tue Apr 16 23:25:29 2013
Log:      Fixed evaluation order problem found by GCMole.

[email protected]

Review URL: https://codereview.chromium.org/14178006
http://code.google.com/p/v8/source/detail?r=14295

Modified:
 /branches/bleeding_edge/src/runtime.cc

=======================================
--- /branches/bleeding_edge/src/runtime.cc      Tue Apr 16 07:55:09 2013
+++ /branches/bleeding_edge/src/runtime.cc      Tue Apr 16 23:25:29 2013
@@ -825,8 +825,8 @@
   ASSERT(byte_length % elementSize == 0);
   size_t length = byte_length / elementSize;

-  holder->set_length(
-      *isolate->factory()->NewNumber(static_cast<double>(length)));
+  Handle<Object> length_obj = isolate->factory()->NewNumber(length);
+  holder->set_length(*length_obj);
   Handle<ExternalArray> elements =
       isolate->factory()->NewExternalArray(
           static_cast<int>(length), arrayType,

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to