DBC (only looked at ia32 changes).
https://codereview.chromium.org/14371005/diff/1/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (left):
https://codereview.chromium.org/14371005/diff/1/src/ia32/lithium-codegen-ia32.cc#oldcode357
src/ia32/lithium-codegen-ia32.cc:357: Comment(";;; @%d: %s. <of #%d %s
for #%d %s>",
I found it very helpful to have these comments. If you come up with a
replacement soon-ish, it's fine to land this as is, otherwise I'd favor
reverting this part of the change for now.
https://codereview.chromium.org/14371005/diff/1/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/14371005/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode347
src/ia32/lithium-codegen-ia32.cc:347: Comment(";;; <%d,%d> %s",
For grep-ability, I like having a '#' before the hydrogen ID. By the
same reasoning you may want to keep the '@' before the Lithium ID
(personally I don't care much about those), so we'd have ";;; <@%d, #%d>
%s".
https://codereview.chromium.org/14371005/diff/1/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):
https://codereview.chromium.org/14371005/diff/1/src/ia32/lithium-ia32.cc#newcode214
src/ia32/lithium-ia32.cc:214: return
!gen->IsNextEmittedBlock(block_id());
As discussed, to make sure this condition is in sync with when to emit
an instruction, there should be a helper method "MustEmitInstruction()"
or similar that's called in both places.
https://codereview.chromium.org/14371005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
