Uploading a CL with the changes soon...
https://codereview.chromium.org/14371005/diff/1/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (left):
https://codereview.chromium.org/14371005/diff/1/src/ia32/lithium-codegen-ia32.cc#oldcode357
src/ia32/lithium-codegen-ia32.cc:357: Comment(";;; @%d: %s. <of #%d %s
for #%d %s>",
On 2013/04/22 09:19:59, Jakob wrote:
I found it very helpful to have these comments. If you come up with a
replacement soon-ish, it's fine to land this as is, otherwise I'd
favor
reverting this part of the change for now.
As discussed offline, this can and should be handled differently:
Sometimes we need this info, sometimes we need to see the values of some
flags, etc. Perhaps we should just emit what --trace-hydrogen emits.
I'll remove the stuff for now, having the cruel hack here really hurts
readability.
https://codereview.chromium.org/14371005/diff/1/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/14371005/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode347
src/ia32/lithium-codegen-ia32.cc:347: Comment(";;; <%d,%d> %s",
On 2013/04/22 09:19:59, Jakob wrote:
For grep-ability, I like having a '#' before the hydrogen ID. By the
same
reasoning you may want to keep the '@' before the Lithium ID
(personally I don't
care much about those), so we'd have ";;; <@%d, #%d> %s".
Done.
https://codereview.chromium.org/14371005/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode2196
src/ia32/lithium-codegen-ia32.cc:2196: int destination =
chunk_->LookupDestination(block);
Ooops, this should really use the IsNextEmittedBlock predicate to keep
things in sync, even if this means that we have to look through dead
blocks again (which I probably not a performance killer ;-).
https://codereview.chromium.org/14371005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
