LGTM with nits.
https://codereview.chromium.org/14119008/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
https://codereview.chromium.org/14119008/diff/1/src/arm/code-stubs-arm.cc#newcode1896
src/arm/code-stubs-arm.cc:1896: // Load left and right operands into d6
and d7.
Load left and right operands into d0 and d1.
https://codereview.chromium.org/14119008/diff/1/src/arm/code-stubs-arm.cc#newcode1898
src/arm/code-stubs-arm.cc:1898: __ SmiUntag(scratch1, r0);
We can use left and right instead of r1 and r0.
https://codereview.chromium.org/14119008/diff/1/src/arm/code-stubs-arm.cc#newcode1905
src/arm/code-stubs-arm.cc:1905: // Load right operand to d7 or r2/r3.
Obsolete comments here and below.
https://codereview.chromium.org/14119008/diff/1/src/arm/macro-assembler-arm.h
File src/arm/macro-assembler-arm.h (right):
https://codereview.chromium.org/14119008/diff/1/src/arm/macro-assembler-arm.h#newcode498
src/arm/macro-assembler-arm.h:498: // Convert the smi or heap number in
object to an int32 using the rules
"Converts"
https://codereview.chromium.org/14119008/diff/1/src/arm/macro-assembler-arm.h#newcode512
src/arm/macro-assembler-arm.h:512: // The value ends up either in |dst|.
"Loads the number from object into dst register."
https://codereview.chromium.org/14119008/diff/1/src/arm/macro-assembler-arm.h#newcode521
src/arm/macro-assembler-arm.h:521: // Load the number from object into
double_dst in the double format.
"Loads"
https://codereview.chromium.org/14119008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
