A few DBCs...
https://codereview.chromium.org/14403015/diff/1/src/handles.h
File src/handles.h (right):
https://codereview.chromium.org/14403015/diff/1/src/handles.h#newcode363
src/handles.h:363: HandleDereferenceGuard allow(Isolate::Current(),
\
Please do *not* introduce any new Isolate::Current() calls, this
function is really on death row. Adding another parameter to the macro
is probably the easiest way for this, the right Isolate is probably
easily available at all call sites, anyway.
https://codereview.chromium.org/14403015/diff/1/src/isolate.cc
File src/isolate.cc (right):
https://codereview.chromium.org/14403015/diff/1/src/isolate.cc#newcode511
src/isolate.cc:511: bool Isolate::IsDeferredHandle(Object** location) {
Some comment would be very appropriate here: It is very hard to
understand what the code below is actually doing and why. Even better:
Instead of commenting it, rip it apart into easily understandable
methods.
https://codereview.chromium.org/14403015/diff/1/src/isolate.cc#newcode520
src/isolate.cc:520: for (int i = 1; i < blocks->length(); i++) {
Why 1 and not 0? Could be correct, but I don't have a clue.
https://codereview.chromium.org/14403015/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
