Okay, just a few comments. Looking good...I like the reason string for
exceptions to handle deref.
https://codereview.chromium.org/14403015/diff/5001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/14403015/diff/5001/src/hydrogen-instructions.h#newcode4899
src/hydrogen-instructions.h:4899:
ASSERT(!constructor->shared()->IsInobjectSlackTrackingInProgress());
I like the assert but how do you know slack tracking must be finished
for this object/map?
https://codereview.chromium.org/14403015/diff/5001/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/14403015/diff/5001/src/ia32/lithium-codegen-ia32.cc#newcode6206
src/ia32/lithium-codegen-ia32.cc:6206: if (!pretenure &&
instr->hydrogen()->has_no_literals()) {
I understand the freezing of information into the hydrogen instruction,
like has_no_literals(). But it's confusing to see that you still make
the shared_info() available too. If it's an unsafe structure to peer
into, then why can you get access to it? It's just so you can push the
pointer for the calls below? In that case I'd rather see the declaration
for the local shared_info removed, and just pass
instr()->hydrogen()->shared_info() in the __ push calls below.
https://codereview.chromium.org/14403015/diff/5001/src/isolate.cc
File src/isolate.cc (right):
https://codereview.chromium.org/14403015/diff/5001/src/isolate.cc#newcode531
src/isolate.cc:531: }
Why can't the check of the first block in the list be integrated with
the loop, which uses code like
int block_size = i == 0 ? deferred->first_block_limit_ :
kHandleBlockSize;
and then
"handle < blocks->at(0) + block_size"
is it because at(0) doesn't work for the first, partially full block?
https://codereview.chromium.org/14403015/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
