On 2013/04/23 13:18:08, Sven Panne wrote:
https://codereview.chromium.org/14429003/diff/1/src/arm/regexp-macro-assembler-arm.cc
File src/arm/regexp-macro-assembler-arm.cc (right):
https://codereview.chromium.org/14429003/diff/1/src/arm/regexp-macro-assembler-arm.cc#newcode383
src/arm/regexp-macro-assembler-arm.cc:383: __ mov(r3,
Operand(ExternalReference::isolate_address(masm_->isolate())));
Add a
Isolate* RegExpMacroAssemblerARM::isolate() const { return
masm_->isolate();
}
here and at the other RegExpMacroAssemblers, we did similar things for
other
classes. It's a good thing that the caller doesn't need to know the
details
where to fetch the Isolate.
https://codereview.chromium.org/14429003/diff/1/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):
https://codereview.chromium.org/14429003/diff/1/src/arm/stub-cache-arm.cc#newcode1298
src/arm/stub-cache-arm.cc:1298: __ Move(scratch3(),
Handle<Object>(callback->data(), masm()->isolate()));
StubCompiler has an isolate() method, so use this here and elsewhere.
https://codereview.chromium.org/14429003/diff/1/src/x64/deoptimizer-x64.cc
File src/x64/deoptimizer-x64.cc (right):
https://codereview.chromium.org/14429003/diff/1/src/x64/deoptimizer-x64.cc#newcode656
src/x64/deoptimizer-x64.cc:656: Isolate* isolate = masm()->isolate();
Again: Add an isolate() method to EntryGenerator (here and on other
platforms).
Addressed comments. Please take another look.
https://codereview.chromium.org/14429003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
