LGTM with a few nits.
https://codereview.chromium.org/14429003/diff/6001/src/arm/regexp-macro-assembler-arm.h
File src/arm/regexp-macro-assembler-arm.h (right):
https://codereview.chromium.org/14429003/diff/6001/src/arm/regexp-macro-assembler-arm.h#newcode227
src/arm/regexp-macro-assembler-arm.h:227: inline Isolate* isolate() {
return masm_->isolate(); }
Remove "inline", add "const".
https://codereview.chromium.org/14429003/diff/6001/src/ia32/regexp-macro-assembler-ia32.h
File src/ia32/regexp-macro-assembler-ia32.h (right):
https://codereview.chromium.org/14429003/diff/6001/src/ia32/regexp-macro-assembler-ia32.h#newcode200
src/ia32/regexp-macro-assembler-ia32.h:200: inline Isolate* isolate()
const { return masm_->isolate(); }
I don't think "inline" is really needed here, we add this far too often,
anyway.
https://codereview.chromium.org/14429003/diff/6001/src/mips/regexp-macro-assembler-mips.h
File src/mips/regexp-macro-assembler-mips.h (right):
https://codereview.chromium.org/14429003/diff/6001/src/mips/regexp-macro-assembler-mips.h#newcode232
src/mips/regexp-macro-assembler-mips.h:232: inline Isolate* isolate() {
return masm_->isolate(); }
Remove "inline", add "const.
https://codereview.chromium.org/14429003/diff/6001/src/x64/regexp-macro-assembler-x64.h
File src/x64/regexp-macro-assembler-x64.h (right):
https://codereview.chromium.org/14429003/diff/6001/src/x64/regexp-macro-assembler-x64.h#newcode275
src/x64/regexp-macro-assembler-x64.h:275: inline Isolate* isolate()
const { return masm_.isolate(); }
Remove "inline".
https://codereview.chromium.org/14429003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
