more comments
https://codereview.chromium.org/14146005/diff/33001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/14146005/diff/33001/src/objects.cc#newcode2172
src/objects.cc:2172: // If fields were added (or removed), rewrite the
instance.
ASSERT(target_number_of_fileds >= NumberOfFields())
https://codereview.chromium.org/14146005/diff/33001/src/objects.cc#newcode2294
src/objects.cc:2294: MaybeObject* Map::CopyGeneralizeRepresentation(
CopyGeneralizeAllRepresentations
https://codereview.chromium.org/14146005/diff/33001/src/objects.cc#newcode2308
src/objects.cc:2308: if (is_invalid_transition()) return;
Stack overflow?
https://codereview.chromium.org/14146005/diff/33001/src/objects.cc#newcode2478
src/objects.cc:2478: int descriptor =
split_map->NumberOfOwnDescriptors();
split_descriptors
https://codereview.chromium.org/14146005/diff/33001/src/objects.cc#newcode2488
src/objects.cc:2488: for (; descriptor < descriptors; descriptor++) {
maybe a separate loop variable?
https://codereview.chromium.org/14146005/diff/33001/src/objects.cc#newcode2495
src/objects.cc:2495: Handle<Map>(new_map);
Please try to test this with a crazy big object example
https://codereview.chromium.org/14146005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
