generally lgtm, but waiting for ARM port
https://codereview.chromium.org/14146005/diff/25/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/14146005/diff/25/src/objects.cc#newcode7289
src/objects.cc:7289: int current_offset = 0;
// 0 -> 'verbatim'
https://codereview.chromium.org/14146005/diff/25/src/objects.cc#newcode7296
src/objects.cc:7296: Name* key = GetKey(descriptor);
// |verbatim| -> |valid|
https://codereview.chromium.org/14146005/diff/25/src/objects.cc#newcode7302
src/objects.cc:7302: ASSERT(other_details.type() != CALLBACKS);
// Assert not correct?
https://codereview.chromium.org/14146005/diff/25/src/objects.cc#newcode7310
src/objects.cc:7310: result->Set(descriptor, &d, witness);
Merge this case with the previous one.
https://codereview.chromium.org/14146005/diff/25/src/objects.cc#newcode7339
src/objects.cc:7339: result->CopyFrom(descriptor, other, descriptor,
witness);
Simplify logic as discussed. Either generate a field or copy, test
should be unified.
https://codereview.chromium.org/14146005/diff/25/src/objects.cc#newcode7343
src/objects.cc:7343: for (; descriptor < new_size; descriptor++) {
// |valid| -> new_size
https://codereview.chromium.org/14146005/diff/25/src/property-details.h
File src/property-details.h (right):
https://codereview.chromium.org/14146005/diff/25/src/property-details.h#newcode132
src/property-details.h:132: uint8_t DetailsEncoded() {
Move this encoding to PropertyDetails
https://codereview.chromium.org/14146005/diff/25/src/property-details.h#newcode183
src/property-details.h:183: PropertyDetails
set_representation(Representation representation) {
CopyForRepresentation
https://codereview.chromium.org/14146005/diff/25/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/14146005/diff/25/src/runtime.cc#newcode253
src/runtime.cc:253: // most from the beginning. However, since it may go
slow by adding
Elaborate, please :-) (fast)
https://codereview.chromium.org/14146005/diff/25/src/runtime.cc#newcode267
src/runtime.cc:267: // TODO(verwaest): Support tracking representations
in the boilerplate.
Remove all this code, insert TODO
https://codereview.chromium.org/14146005/diff/25/src/stub-cache.cc
File src/stub-cache.cc (right):
https://codereview.chromium.org/14146005/diff/25/src/stub-cache.cc#newcode939
src/stub-cache.cc:939: Code::StubType type = handlers->at(0)->type();
Use number_of_valid_maps
https://codereview.chromium.org/14146005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
