LGTM, with two nits
https://codereview.chromium.org/13982023/diff/1/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/13982023/diff/1/src/heap.h#newcode1868
src/heap.h:1868: heap_->relocation_mutex_locked_by_optimizer_thread_ =
false;
Just set it to false if the destructor is called by the optimizing
compiler thread.
https://codereview.chromium.org/13982023/diff/1/src/heap.h#newcode1875
src/heap.h:1875: static bool IsLockedByOptimizerThread(Heap* heap) {
I think you may want to avoid static methods since there may be multiple
optimizing compiler threads per process.
https://codereview.chromium.org/13982023/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
