https://codereview.chromium.org/14253015/diff/2001/src/cpu-profiler.cc
File src/cpu-profiler.cc (right):
https://codereview.chromium.org/14253015/diff/2001/src/cpu-profiler.cc#newcode510
src/cpu-profiler.cc:510: printf("CompilationInfo size = %lu\n",
sizeof(CompilationInfo));
please remove that
https://codereview.chromium.org/14253015/diff/2001/src/cpu-profiler.cc#newcode510
src/cpu-profiler.cc:510: printf("CompilationInfo size = %lu\n",
sizeof(CompilationInfo));
please remove that
https://codereview.chromium.org/14253015/diff/2001/src/profile-generator-inl.h
File src/profile-generator-inl.h (right):
https://codereview.chromium.org/14253015/diff/2001/src/profile-generator-inl.h#newcode59
src/profile-generator-inl.h:59: frame_setup_offset_(-1),
please use -1 or the constant everywhere
https://codereview.chromium.org/14253015/diff/2001/src/profile-generator-inl.h#newcode59
src/profile-generator-inl.h:59: frame_setup_offset_(-1),
please use -1 or the constant everywhere
https://codereview.chromium.org/14253015/diff/2001/src/profile-generator.cc
File src/profile-generator.cc (right):
https://codereview.chromium.org/14253015/diff/2001/src/profile-generator.cc#newcode915
src/profile-generator.cc:915: return;
looks like you are skipping the other stack traces.
https://codereview.chromium.org/14253015/diff/2001/src/profile-generator.cc#newcode919
src/profile-generator.cc:919: return;
ditto
https://codereview.chromium.org/14253015/diff/2001/src/profile-generator.cc#newcode921
src/profile-generator.cc:921: *entry++ = pc_entry;
sounds like you are adding zero entry if the mapping wasn't found.
https://codereview.chromium.org/14253015/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
