LGTM with nits.
Please also update the test expectations for the CPU profiler test (see
https://code.google.com/p/v8/source/browse/branches/bleeding_edge/test/cctest/cctest.status#43
)
https://codereview.chromium.org/14253015/diff/14001/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):
https://codereview.chromium.org/14253015/diff/14001/src/arm/full-codegen-arm.cc#newcode431
src/arm/full-codegen-arm.cc:431: Label exit_codesize;
I don't see what we need this label for.
https://codereview.chromium.org/14253015/diff/14001/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/14253015/diff/14001/src/compiler.cc#newcode106
src/compiler.cc:106: no_frame_ranges_ =
isolate->cpu_profiler()->is_profiling() ?
nit: putting the '?' on the second line is preferable.
https://codereview.chromium.org/14253015/diff/14001/src/compiler.h
File src/compiler.h (right):
https://codereview.chromium.org/14253015/diff/14001/src/compiler.h#newcode268
src/compiler.h:268: // samples where top frame is not setup.
nit: s/setup/set up/
https://codereview.chromium.org/14253015/diff/14001/src/profile-generator.cc
File src/profile-generator.cc (right):
https://codereview.chromium.org/14253015/diff/14001/src/profile-generator.cc#newcode547
src/profile-generator.cc:547: *start = locator.key();
nit: {} please
https://codereview.chromium.org/14253015/diff/14001/src/profile-generator.cc#newcode912
src/profile-generator.cc:912: // If pc is in the function code before it
setup stack frame or after the
nit: s/setup/set up/
https://codereview.chromium.org/14253015/diff/14001/src/profile-generator.cc#newcode914
src/profile-generator.cc:914: // ebp cotains return address of the
current function and skips caller's
nit: contains
https://codereview.chromium.org/14253015/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
