On 2013/04/26 04:38:13, haitao.feng wrote:
https://codereview.chromium.org/13950013/diff/3001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/13950013/diff/3001/src/hydrogen.cc#newcode3745
src/hydrogen.cc:3745: worklist.Add(phi, zone());
Thanks for the review.
It seems that we do not need BitVector for this special case as the
worklist only contains PHIs which might be truncated to int32 (the
assumption
in
the beginning) but could not be truncated as there is a non-truncating
int32
or
a double usage in the first iteration, and a non-truncating PHI usage in
the
following worklist iterations. So there is only one state change for the
PHI
and
a PHI will never be added to the worklist twice.
Makes sense. LGTM. I'll land.
https://codereview.chromium.org/13950013/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
