https://codereview.chromium.org/14451003/diff/13001/src/assembler.cc
File src/assembler.cc (right):
https://codereview.chromium.org/14451003/diff/13001/src/assembler.cc#newcode1208
src/assembler.cc:1208: return ExternalReference(isolate->heap()->
On 2013/05/03 09:33:10, Michael Starzinger wrote:
nit: Use same line-break style as in the other function. Easier to
read.
Done.
https://codereview.chromium.org/14451003/diff/13001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/14451003/diff/13001/src/runtime.cc#newcode239
src/runtime.cc:239: boilerplate =
isolate->factory()->NewJSObjectFromMap(map, TENURED);
On 2013/05/03 09:33:10, Michael Starzinger wrote:
Can we add a "Heap::GetGlobalPretenureFlag()" helper that returns the
correct
PretenureFlag depending on the mode. This simplifies all of the call
sites in
this file.
Done.
https://codereview.chromium.org/14451003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
