LGTM with a final round of comments.
https://codereview.chromium.org/14451003/diff/20001/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/14451003/diff/20001/src/heap.h#newcode1988
src/heap.h:1988: intptr_t new_space_high_promotion_mode_active_;
Can we add a TODO here that this is only "intptr_t" because it is
accessed from generated code. Once we no longer access it from generated
code it should be changed back to "bool".
https://codereview.chromium.org/14451003/diff/20001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/14451003/diff/20001/src/ia32/code-stubs-ia32.cc#newcode7403
src/ia32/code-stubs-ia32.cc:7403: { REG(ecx), REG(edx), REG(ebx),
EMIT_REMEMBERED_SET},
The ecx/edx/ebx stub seems to be duplicated.
https://codereview.chromium.org/14451003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
