LGTM with Sven's comments addressed.
All ia32 comments apply to x64 too.
https://codereview.chromium.org/14856015/diff/16001/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):
https://codereview.chromium.org/14856015/diff/16001/src/ia32/lithium-ia32.cc#newcode1608
src/ia32/lithium-ia32.cc:1608: // than an add. This is the case when no
overflow check is needed and are
nit: s/are/there are/
https://codereview.chromium.org/14856015/diff/16001/src/x64/lithium-x64.cc
File src/x64/lithium-x64.cc (right):
https://codereview.chromium.org/14856015/diff/16001/src/x64/lithium-x64.cc#newcode1539
src/x64/lithium-x64.cc:1539: if (instr->CheckFlag(HValue::kCanOverflow))
{
This condition is now a dupe of the above.
https://codereview.chromium.org/14856015/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
