https://codereview.chromium.org/14676011/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/14676011/diff/1/src/hydrogen-instructions.h#newcode813
src/hydrogen-instructions.h:813: // used during dead code elimination to
indicate the instruction is live
nit: Our style guide demands that comments be proper sentences,
beginning with a capital letter and ending with appropriate punctuation.
This remark applies to most comments introduced in this CL.
https://codereview.chromium.org/14676011/diff/1/src/hydrogen-instructions.h#newcode1077
src/hydrogen-instructions.h:1077: bool IsDead() const {
I think this can be removed. It only had two call sites AFAICS, and both
are deleted in this CL.
https://codereview.chromium.org/14676011/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/14676011/diff/1/src/hydrogen.cc#newcode4858
src/hydrogen.cc:4858: if (FLAG_dead_code_elimination)
DeadCodeElimination();
On 2013/05/07 13:32:10, Sven Panne wrote:
I am not sure if this is what we want: Almost all our bots run without
DCE,
because our tests consist of a lot of dead code. If we don't do this
phase here,
we fundamentally change things. Perhaps keep the old flag for this DCE
phase?
I'm a bit torn, adding Jakob for a 2nd opinion...
As discussed offline, it's probably OK to leave this as it is. We'll
have more dead phis when running tests, but that shouldn't affect
coverage negatively.
https://codereview.chromium.org/14676011/diff/1/src/hydrogen.cc#newcode5420
src/hydrogen.cc:5420: ZoneList<HPhi*> philist(blocks_.length(), zone());
Why do we need this phi list at all? Can't we simply iterate through all
blocks and each block's phi list when trying to eliminate dead phis?
(I.e. have a loop similar to the one in lines 5431-5435 inserted before
5454, instead of the loop in 5457-5463).
Remember, zone memory can't be freed unless the entire zone is nuked.
Zone allocation is fast, but the memory used by the objects stays around
when the C++ variables go out of scope.
https://codereview.chromium.org/14676011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
