Final round, I think. :-) Apart from the IsDeletable comment, why do we have
several unit test files? (This was in my previous comments, too.) I can
neither
see an advantage in splitting the tests up nor some kind of reasoning
behind the
current partitioning, which looks rather random to me.
https://codereview.chromium.org/14676011/diff/18001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/14676011/diff/18001/src/hydrogen.cc#newcode5425
src/hydrogen.cc:5425: if (phi->IsReceiver()) MarkLive(NULL, phi,
&worklist);
Can we move this check into HPhi::IsDeletable? This way, we could
consistently write
if (!instr->CanBeEliminated()) MarkLive(NULL, instr, &worklist);
https://codereview.chromium.org/14676011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
