What I don't like about this patch in its current form is the inconsistency
it
introduces to the various OS-based conditions in the .gyp files. We should
settle for either of:
(1) OS=="a" or OS=="b" or...
(2) OS!="win"
(3) OS in "a b ...".split()
(4) OS in ["a", "b", ...]
and then use that consistently. Moving some of these lists to global
variables
would be very nice too, but a little messy in practice due to subtle
differences
(sometimes we test for "Linux or *BSD or Mac", sometimes for "Linux or
*BSD",
sometimes what we really mean is "do we compile with GCC", and so on).
https://codereview.chromium.org/11421013/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
