On 2013/05/15 12:55:46, Jakob wrote:
[...] Moving some of these lists to global variables
would be very nice too, but a little messy in practice due to subtle
differences
(sometimes we test for "Linux or *BSD or Mac", sometimes for "Linux or
*BSD",
sometimes what we really mean is "do we compile with GCC", and so on).
I think we should slowly move towards a feature-based approach in our
build-system, too, e.g. define a variable IS_POSIX_LIKE based on 'OS in
["blah",
"bloh", ...]' and use that to include platform_posix.cc in the build.
Similarly
we could handle other features like "no strict aliasing, please", "supports
execinfo" etc.
But you are right, as a first step using one of (1)..(4) consistently makes
sense. I would opt for (4). (1) too repetitive, instead of (2) I would
prefer
positive formulations, and (3) won't work for platforms with whitespace in
its
name (*very* common, but nevertheless ;-)
https://codereview.chromium.org/11421013/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
