drive by comments on arm
https://codereview.chromium.org/15303004/diff/5001/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
https://codereview.chromium.org/15303004/diff/5001/src/arm/lithium-codegen-arm.cc#newcode4712
src/arm/lithium-codegen-arm.cc:4712: __ SmiTag(ToRegister(output),
ToRegister(input));
SetCC
https://codereview.chromium.org/15303004/diff/5001/src/arm/lithium-codegen-arm.cc#newcode5173
src/arm/lithium-codegen-arm.cc:5173: DeoptimizeIf(ne,
instr->environment());
This code doesn't handle -0.
https://codereview.chromium.org/15303004/diff/5001/src/arm/lithium-codegen-arm.cc#newcode5175
src/arm/lithium-codegen-arm.cc:5175: __ bind(&done);
Nothing branch to this label.
https://codereview.chromium.org/15303004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
