https://chromiumcodereview.appspot.com/15303004/diff/9001/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):
https://chromiumcodereview.appspot.com/15303004/diff/9001/src/ia32/lithium-ia32.cc#newcode2053
src/ia32/lithium-ia32.cc:2053: return
AssignEnvironment(DefineSameAsFirst(new(zone()) LCheckSmi(value)));
This change causes unnecessary register pressure, because it makes the
register allocater think that LCheckSmi overwrites its input register.
Also, it is missing from the ARM port of this patch, making
--trace-hydrogen segfault on ARM.
I think we should introduce a separate LCheckSmiAndReturn instruction
for the use case in DoChange() above, and keep the original LCheckSmi
unmodified (i.e. not returning a value).
https://chromiumcodereview.appspot.com/15303004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
