https://codereview.chromium.org/15504002/diff/2001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/15504002/diff/2001/src/objects.cc#newcode1993
src/objects.cc:1993: uint32_t index,
Nit: indentation seems off here.
https://codereview.chromium.org/15504002/diff/2001/src/objects.cc#newcode1999
src/objects.cc:1999: if (object->IsJSGlobalObject()) {
Can this even happen? Do we ever emit splices for non-arrays?
https://codereview.chromium.org/15504002/diff/2001/src/objects.cc#newcode2004
src/objects.cc:2004: Handle<Object> delete_count_object =
It's not obvious why we need the delete_count here...why don't we just
pass the correct deleted array?
https://codereview.chromium.org/15504002/diff/2001/src/objects.cc#newcode2022
src/objects.cc:2022: if (object->IsJSGlobalObject()) {
Same question as above, can this happen?
https://codereview.chromium.org/15504002/diff/2001/src/objects.cc#newcode2038
src/objects.cc:2038: if (object->IsJSGlobalObject()) {
ditto
https://codereview.chromium.org/15504002/diff/2001/src/objects.cc#newcode10811
src/objects.cc:10811: int_indices.Add(i);
It seems odd to keep track of the indices twice. Any reason not to store
them only as ints and then generate strings below when needed?
https://codereview.chromium.org/15504002/diff/2001/test/mjsunit/harmony/object-observe.js
File test/mjsunit/harmony/object-observe.js (right):
https://codereview.chromium.org/15504002/diff/2001/test/mjsunit/harmony/object-observe.js#newcode1040
test/mjsunit/harmony/object-observe.js:1040:
assertSame(spliceRecords.length, 1);
Any reason not to use assertEquals() for everything except object
identity?
https://codereview.chromium.org/15504002/diff/2001/test/mjsunit/harmony/object-observe.js#newcode1050
test/mjsunit/harmony/object-observe.js:1050:
assertSame(splice.removed[499999900], 'hello');
Probably also want to check splice.removed.length (which should be
999999900)
https://codereview.chromium.org/15504002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
