ptal

https://codereview.chromium.org/15504002/diff/2001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/15504002/diff/2001/src/objects.cc#newcode1999
src/objects.cc:1999: if (object->IsJSGlobalObject()) {
These only get called from within objects.cc, but I've made it so that
all three take Handle<JSArray>

On 2013/05/21 19:11:11, adamk wrote:
On 2013/05/20 23:52:06, rafaelw wrote:
> Replaced with assert.

Now that you've added the assert I'm wondering what happens with:

var global = this;
global.length = 0;
Array.prototype.push.call(global, 75);

So perhaps I was wrong...

> On 2013/05/20 23:13:13, adamk wrote:
> > Can this even happen? Do we ever emit splices for non-arrays?
>


https://codereview.chromium.org/15504002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to