https://codereview.chromium.org/16095004/diff/1/src/hydrogen.h
File src/hydrogen.h (right):
https://codereview.chromium.org/16095004/diff/1/src/hydrogen.h#newcode1949
src/hydrogen.h:1949: class SparseSet {
I think it makes sense to move this to a separate file, too, or at least
put it somewhere else, there is nothing hydrogen-specific here. In
general, I would like to see some general data structure subdirectory,
but perhaps that's just me... :-)
https://codereview.chromium.org/16095004/diff/1/src/hydrogen.h#newcode1988
src/hydrogen.h:1988: class HGlobalValueNumberer BASE_EMBEDDED {
To be consistent, this should really live in a new hydrogen-gvn.h file.
https://codereview.chromium.org/16095004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
