LGTM if exposing GetIsolate() is really what we want in the long run,
otherwise
make it private and go ahead.
https://codereview.chromium.org/16021010/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/16021010/diff/1/include/v8.h#newcode2793
include/v8.h:2793: V8_INLINE(Isolate* GetIsolate());
Do we really want to expose GetIsolate() or would it be better to keep
that private as an implementation detail? I don't know what the master
plan is, so it might be OK or not. This is part of an external API and
we should be careful with exposing things here, people might actually
use it. ;-)
https://codereview.chromium.org/16021010/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
